Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace java assert on something else #9402

Open
Captain1653 opened this issue Oct 16, 2024 · 0 comments
Open

Replace java assert on something else #9402

Captain1653 opened this issue Oct 16, 2024 · 0 comments
Assignees
@tomas-langer
Labels
4.x Version 4.x design This issue requires design/architecture decisions P4

Comments

@Captain1653
Copy link
Contributor

Environment Details

  • Helidon Version: 4.x, 3.x, 2.x
  • Helidon SE or Helidon MP: not applicable
  • JDK version: not applicable
  • OS: not applicable
  • Docker version (if applicable):

Problem Description

There are many usages assert keyword.
Screenshot 2024-10-16 at 11 42 11

But assert is disabled by default. I'm sure, that it's enabled for the pipeline in helidon, but it can be forgotten in some cases (some migrations, for example).

Will it be better to use Objects.requireNonNull or other enabled by default assertions for these cases?
@m0mus m0mus added 4.x Version 4.x design This issue requires design/architecture decisions labels Oct 17, 2024
@m0mus m0mus added the P4 label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomas-langer tomas-langer

Labels
4.x Version 4.x design This issue requires design/architecture decisions P4
Projects
Backlog
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Captain1653 @m0mus @tomas-langer