Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] - Wrong Tracing/Zipkin config created when using Project Starter #8071

Closed
dalexandrov opened this issue Nov 23, 2023 · 1 comment · Fixed by #8141
Closed

[3.x] - Wrong Tracing/Zipkin config created when using Project Starter #8071

dalexandrov opened this issue Nov 23, 2023 · 1 comment · Fixed by #8141
Assignees
Labels
3.x Issues for 3.x version branch archetypes bug Something isn't working P2 SE tracing
Milestone

Comments

@dalexandrov
Copy link
Contributor

dalexandrov commented Nov 23, 2023

Environment Details

  • Helidon Version: 3.2.3
  • Helidon SE
  • JDK version: 17/21
  • OS: OSX

When creating Helidon SE version 3.2.3 project using starter, with Zipkin Tracing
https://helidon.io/starter/3.2.3?step=9&app-type=custom&tracing=true&tracing.provider=zipkin

wrong tracing configuration is created:

tracing:
  zipkin:
    service: "helidon-service"
    protocol: "https"
    host: "192.168.1.1"
    port: 9987
    api-version: 1
    # this is the default path for API version 2
    path: "/api/v2/spans"
    tags:
      tag1: "tag1-value"
      tag2: "tag2-value"
    boolean-tags:
      tag3: true
      tag4: false
    int-tags:
      tag5: 145
      tag6: 741

the application fails to start.

The proposed config is:

tracing:
  service: "helidon-service"
  protocol: "https"
  host: "192.168.1.1"
  port: 9987
  api-version: 1
  # this is the default path for API version 2
  path: "/api/v2/spans"
  tags:
    tag1: "tag1-value"
    tag2: "tag2-value"
  boolean-tags:
    tag3: true
    tag4: false
  int-tags:
    tag5: 145
    tag6: 741
@dalexandrov dalexandrov added bug Something isn't working SE tracing 3.x Issues for 3.x version branch labels Nov 23, 2023
@dalexandrov
Copy link
Contributor Author

host: "192.168.1.1" is also proposed to be different. For example localhost.

@m0mus m0mus added the P2 label Dec 6, 2023
@m0mus m0mus added this to the 4.0.2 milestone Dec 6, 2023
@barchetta barchetta modified the milestones: 4.0.2, 2.6.5, 3.2.5 Dec 7, 2023
@tvallin tvallin linked a pull request Dec 12, 2023 that will close this issue
@tvallin tvallin closed this as completed Dec 13, 2023
@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues for 3.x version branch archetypes bug Something isn't working P2 SE tracing
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants