Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally gernerate module-info.java for helidon projects generated by cli #7226

Closed
Sineaggi opened this issue Jul 19, 2023 · 1 comment
Closed
Assignees
Labels

Comments

@Sineaggi
Copy link

Sineaggi commented Jul 19, 2023

Environment Details

  • Helidon Version: 4.0.0-M1
  • Helidon SE or Helidon MP
  • JDK version: 21-ea+31
  • OS: macos venture 14.1
  • Docker version (if applicable): n/a

Problem Description

The helidon cli does not generate an example module-info.java file. This means users desiring to modularize their applications would be expected to supply their own.
I would expect that pre-generated module-info.java files containing all the necessary modules in the selected archetype to have been included by default.

Steps to reproduce

Running

helidon init --version 4.0.0-M1

generates an application without a module-info.java file.

@Sineaggi
Copy link
Author

The default nima quickstart module-info.java would look something like

module quickstart.nima {
    requires io.helidon.logging.common;
    requires io.helidon.config;
    requires io.helidon.nima.webserver;
    requires io.helidon.nima.webclient;
    requires io.helidon.nima.observe;
    requires io.helidon.nima.observe.health;
    requires io.helidon.health.checks;
    requires jakarta.json;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

4 participants