Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request routing does not propagate throwable from next(Throwable) #6550

Closed
tomas-langer opened this issue Apr 4, 2023 · 1 comment · Fixed by #6699
Closed

Request routing does not propagate throwable from next(Throwable) #6550

tomas-langer opened this issue Apr 4, 2023 · 1 comment · Fixed by #6699
Assignees
@romain-grecourt
Labels
3.x Issues for 3.x version branch bug Something isn't working P2 team-fix This issue is available for team members to be fixed. Should not require deep knowledge of Helidon webserver
Milestone
3.2.1

Comments

@tomas-langer
Copy link
Member

tomas-langer commented Apr 4, 2023 •
edited
Loading

When next(Throwable) is called, the implementation class RequestRouting calls checkNexted() without a parameter.
As a result, if checkNexted() fails, we lose the original throwable.
The fix is to call checkNexted(Throwable) instead.

This happens if you call next() and next(someThrowable) -> the someThrowable is lost
@tomas-langer tomas-langer added bug Something isn't working webserver 3.x Issues for 3.x version branch team-fix This issue is available for team members to be fixed. Should not require deep knowledge of Helidon labels Apr 4, 2023
@m0mus m0mus added the P2 label Apr 6, 2023
@romain-grecourt
Copy link
Contributor

romain-grecourt commented Apr 6, 2023 •
edited
Loading 

req.next();
req.next(new Exception("booh"));

@barchetta barchetta added this to the 3.2.1 milestone Apr 6, 2023
romain-grecourt added a commit to romain-grecourt/helidon that referenced this issue Apr 26, 2023
@romain-grecourt
Use checkNested(Throwable) for req.next(Throwable) to always propagat…
f2dc8f4 
…e the exception.

Fixes helidon-io#6550
@romain-grecourt romain-grecourt mentioned this issue Apr 26, 2023
Merged
This was referenced Apr 26, 2023
Closed
Closed
Closed
Closed
@romain-grecourt romain-grecourt changed the title 3.x: Request routing does not propagate throwable from next(Throwable) Request routing does not propagate throwable from next(Throwable) Apr 26, 2023
romain-grecourt added a commit that referenced this issue Apr 27, 2023
@romain-grecourt
Use checkNested(Throwable) for req.next(Throwable) to always propagat…
0e282b5 
…e the exception. (#6699)

Fixes #6550
@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romain-grecourt romain-grecourt

Labels
3.x Issues for 3.x version branch bug Something isn't working P2 team-fix This issue is available for team members to be fixed. Should not require deep knowledge of Helidon webserver
Projects
Backlog
Archived in project
Milestone
3.2.1
Development

Successfully merging a pull request may close this issue.

Use checkNested(Throwable) for req.next(Throwable) romain-grecourt/helidon
4 participants
@romain-grecourt @barchetta @m0mus @tomas-langer