Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lost changes to web site nav panel icons #5760

Closed
tjquinno opened this issue Dec 22, 2022 · 0 comments · Fixed by #5761
Closed

Lost changes to web site nav panel icons #5760

tjquinno opened this issue Dec 22, 2022 · 0 comments · Fixed by #5761
Assignees
@tjquinno
Labels
bug Something isn't working docs website

Comments

@tjquinno
Copy link
Member

tjquinno commented Dec 22, 2022 •
edited
Loading

Environment Details

  • Helidon Version: 3.1.0
  • Helidon SE or Helidon MP
  • JDK version:
  • OS:
  • Docker version (if applicable):

Problem Description

Earlier changes to some icons in the doc page nav panel were lost. (See images provided by Romain.)

Looks like bad conflict resolution during a merge.

Also from Romain: https://github.com/helidon-io/helidon/pull/5263/files#diff-8659217fc6506d676f9845a33c7d8a06a7213d8a715f916116a512c2cf086817R60

Screen Shot 2022-12-22 at 2 52 28 PM
Screen Shot 2022-12-22 at 2 48 41 PM
@tjquinno tjquinno added bug Something isn't working docs website labels Dec 22, 2022
@tjquinno tjquinno self-assigned this Dec 22, 2022
@tjquinno tjquinno mentioned this issue Dec 22, 2022
Merged
@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjquinno tjquinno

Labels
bug Something isn't working docs website
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrectly reverted icons tjquinno/helidon
1 participant
@tjquinno