Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenMetrics-format output missing EOF marker and using unexpected content type #4884

Closed
2 tasks done
tjquinno opened this issue Sep 14, 2022 · 0 comments
Closed
2 tasks done
Assignees
Labels
2.x Issues for 2.x version branch 3.x Issues for 3.x version branch bug Something isn't working metrics

Comments

@tjquinno
Copy link
Member

tjquinno commented Sep 14, 2022

Environment Details

  • Helidon Version: 2.x, 3.x
  • Helidon SE or Helidon MP both
  • JDK version:
  • OS:
  • Docker version (if applicable):

Problem Description

The MicroProfile Metrics spec describes JSON format and OpenMetrics format. https://download.eclipse.org/microprofile/microprofile-metrics-4.0/microprofile-metrics-spec-4.0.html#_openmetrics_format

It then links to a Prometheus format web page, which is very similar to OpenMetrics but not exactly the same.

Users have reported that the Helidon metrics output:

  1. lacks the # EOF final line, and
  2. emits text/plain rather than application/openmetrics-text.

Because of this, downstream Prometheus scrapers reject the output when --enable-feature=exemplar-storage is set.

Steps to reproduce

These steps are from a user description. Need to verify this.

  1. Enable Helidon's exemplar support.
  2. Set up Prometheus to scrape the Helidon service and store examplars.
    The Prometheus console for the service will display an brief, truncated error message about failing to scrape the service's metrics.
@tjquinno tjquinno added bug Something isn't working metrics 2.x Issues for 2.x version branch 3.x Issues for 3.x version branch 4.x Version 4.x labels Sep 14, 2022
@tjquinno tjquinno self-assigned this Sep 14, 2022
@tjquinno tjquinno removed the 4.x Version 4.x label Sep 16, 2022
@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issues for 2.x version branch 3.x Issues for 3.x version branch bug Something isn't working metrics
Projects
Archived in project
Development

No branches or pull requests

1 participant