Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: remove license from some of the generated files #279

Closed
delabassee opened this issue Dec 21, 2018 · 6 comments
Closed

RFE: remove license from some of the generated files #279

delabassee opened this issue Dec 21, 2018 · 6 comments
Assignees
Labels
enhancement New feature or request P5

Comments

@delabassee
Copy link
Contributor

Environment Details

  • Helidon Version: NA
  • Helidon SE or Helidon MP : NA
  • JDK version: NA
  • OS: NA

Problem Description

Right now some of the generated files (mvn archetype:generate) are embedding a license, ex. Dockerfile, app.yaml & application.yaml. If possible to would be nice to remove them in such a case as

  • the singal-to-noise ratio is very high (80%-90%)
  • those license block are not collapsable (YAML limitation)
@barchetta barchetta self-assigned this Jan 3, 2019
@m0mus m0mus added the P5 label Jan 16, 2020
@tomas-langer
Copy link
Member

There are a few files that are not yet fixed:

  1. app.yaml in both SE and MP quickstarts
  2. pom.xml in MP quickstart

All other files are fixed.

@tomas-langer tomas-langer added the enhancement New feature or request label Aug 25, 2021
@Captain1653
Copy link
Contributor

Is it issue still valid after #4887 ?

@felvid
Copy link

felvid commented Jul 25, 2023

The license header is also being generated for the src/main/resources/META-INF/native-image/native-image.properties file for the Database SE archetype of version 3.x.

However, perhaps this file should be removed because two native-image.properties files are being generated for this archetype.

The generation of a native-image.properties file is already defined in archetype/common/files/src/main/resources/META-INF/native-image/__dir__/native-image.properties.mustache.

Also, the src/main/resources/META-INF/native-image/native-image.properties file only sets -H:+RemoveSaturatedTypeFlows, which is enabled by default since GraalVM 20.2.0 (2020-08-18).

@romain-grecourt

@felvid
Copy link

felvid commented Jul 25, 2023

The Database MP archetype of version 3.x also has a file for native-image.properties generation setting Args=-H:+RemoveSaturatedTypeFlows, but this file is being ignored. It is not generated.

https://github.com/helidon-io/helidon/blob/helidon-3.x/archetypes/helidon/src/main/archetype/mp/database/files/src/main/resources/META-INF/native-image/native-image.properties

So maybe it should be deleted as well. Although this one doesn't have the license header.

@romain-grecourt
Copy link
Contributor

@tvallin can you take a look

@tvallin
Copy link
Member

tvallin commented Aug 29, 2023

I think all the copyright header had been removed. Thanks @felvid for your help.

@tvallin tvallin closed this as completed Aug 29, 2023
@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P5
Projects
Archived in project
Development

No branches or pull requests

8 participants