Skip to content

Commit

Permalink
[3.x] Helidon Arquillian module should only depend on MP core #7614
Browse files Browse the repository at this point in the history
Signed-off-by: Jorge Bescos Gascon <[email protected]>
  • Loading branch information
jbescos committed Dec 21, 2023
1 parent d3f7edf commit a6327aa
Show file tree
Hide file tree
Showing 7 changed files with 24 additions and 21 deletions.
12 changes: 5 additions & 7 deletions microprofile/tests/arquillian/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,11 @@
</dependency>
<dependency>
<groupId>io.helidon.microprofile.bundles</groupId>
<artifactId>helidon-microprofile</artifactId>
<exclusions>
<exclusion>
<groupId>io.helidon.health</groupId>
<artifactId>helidon-health-checks</artifactId>
</exclusion>
</exclusions>
<artifactId>helidon-microprofile-core</artifactId>
</dependency>
<dependency>
<groupId>io.helidon.microprofile.metrics</groupId>
<artifactId>helidon-microprofile-metrics</artifactId>
</dependency>
<dependency>
<groupId>junit</groupId>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2018, 2022 Oracle and/or its affiliates.
* Copyright (c) 2018, 2023 Oracle and/or its affiliates.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -48,6 +48,7 @@

import io.helidon.config.mp.MpConfigSources;

import jakarta.enterprise.inject.ResolutionException;
import jakarta.enterprise.inject.se.SeContainer;
import jakarta.enterprise.inject.spi.CDI;
import jakarta.enterprise.inject.spi.DefinitionException;
Expand Down Expand Up @@ -474,7 +475,7 @@ private void cleanupBaseMetrics() {
new BaseRegistryTypeLiteral()).get();
Objects.requireNonNull(metricRegistry);
metricRegistry.removeMatching((m, v) -> true);
} catch (IllegalStateException e) {
} catch (IllegalStateException | ResolutionException e) {
LOGGER.log(Level.WARNING, "Unable to cleanup base metrics", e);
}
}
Expand Down
9 changes: 7 additions & 2 deletions microprofile/tests/tck/tck-fault-tolerance/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,13 @@
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.helidon.microprofile.bundles</groupId>
<artifactId>helidon-microprofile</artifactId>
<groupId>io.helidon.microprofile.metrics</groupId>
<artifactId>helidon-microprofile-metrics</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.helidon.microprofile</groupId>
<artifactId>helidon-microprofile-fault-tolerance</artifactId>
<scope>test</scope>
</dependency>
<dependency>
Expand Down
4 changes: 4 additions & 0 deletions microprofile/tests/tck/tck-health/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@
<artifactId>parsson</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.helidon.microprofile.health</groupId>
<artifactId>helidon-microprofile-health</artifactId>
</dependency>
<dependency>
<groupId>org.eclipse.microprofile.health</groupId>
<artifactId>microprofile-health-tck</artifactId>
Expand Down
4 changes: 0 additions & 4 deletions microprofile/tests/tck/tck-jwt-auth/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.helidon.microprofile.bundles</groupId>
<artifactId>helidon-microprofile-core</artifactId>
</dependency>
<dependency>
<groupId>io.helidon.microprofile.jwt</groupId>
<artifactId>helidon-microprofile-jwt-auth</artifactId>
Expand Down
5 changes: 5 additions & 0 deletions microprofile/tests/tck/tck-openapi/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@
<artifactId>arquillian-testng-container</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.helidon.microprofile.openapi</groupId>
<artifactId>helidon-microprofile-openapi</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.eclipse.microprofile.openapi</groupId>
<artifactId>microprofile-openapi-api</artifactId>
Expand Down
6 changes: 0 additions & 6 deletions microprofile/tests/tck/tck-reactive-operators/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,6 @@
<artifactId>helidon-arquillian</artifactId>
<version>${project.version}</version>
<scope>test</scope>
<exclusions>
<exclusion>
<groupId>io.helidon.microprofile.bundles</groupId>
<artifactId>helidon-microprofile-3.1</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>io.helidon.microprofile.reactive-streams</groupId>
Expand Down

0 comments on commit a6327aa

Please sign in to comment.