Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xml-introspection.S causes rtkit-daemon to have an executable stack #15

Closed
mkszuba opened this issue Mar 24, 2020 · 2 comments
Closed

Comments

@mkszuba
Copy link

mkszuba commented Mar 24, 2020

This has already been both reported and explained in the Arch Linux bug tracker (https://bugs.archlinux.org/task/65699) so let me just mention here, for completeness, that setting the stack markings by adding

#if defined(__linux__) && defined(__ELF__)
.section .note.GNU-stack,"",%progbits
#endif

at the beginining of xml-introspection.S makes the problem go away without, as far as I can tell from using a thus modified version of rtkit under Gentoo, any drawbacks.

This solution comes straight from generic Gentoo instructions for dealing with the executable stack and I take no credit for it, which is why I am posting it in an issue rather than submitting a pull request.

@heftig
Copy link
Owner

heftig commented Mar 24, 2020

The current master replaces the use of assembler with xxd to convert the file into C code. The resulting file will be distributed in the tarballs, so xxd is not necessary.

@mkszuba
Copy link
Author

mkszuba commented Mar 25, 2020

Gah, I really should look at the master branch and not just at 0.12 before doing anything here. This is why I initially omitted meson while making libsystemd optional, too... Anyway, that's handy - and come next release, no more patches in Gentoo ebuilds of rtkit!

@mkszuba mkszuba closed this as completed Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants