From 83412dab4c61cd4c1ca8da499885b94bba9be05e Mon Sep 17 00:00:00 2001 From: Heemin Kim Date: Mon, 29 Jul 2024 14:52:43 -0700 Subject: [PATCH] Remove additionalSettings Per https://github.com/opensearch-project/OpenSearch/pull/9392, mmap will be a default setting for all lucene segment files Signed-off-by: Heemin Kim --- .../org/opensearch/knn/plugin/KNNPlugin.java | 21 ------------------- 1 file changed, 21 deletions(-) diff --git a/src/main/java/org/opensearch/knn/plugin/KNNPlugin.java b/src/main/java/org/opensearch/knn/plugin/KNNPlugin.java index 5301b6e4e2..8788ef087a 100644 --- a/src/main/java/org/opensearch/knn/plugin/KNNPlugin.java +++ b/src/main/java/org/opensearch/knn/plugin/KNNPlugin.java @@ -354,25 +354,4 @@ public List getNamedXContent() { public Collection getSystemIndexDescriptors(Settings settings) { return ImmutableList.of(new SystemIndexDescriptor(MODEL_INDEX_NAME, "Index for storing models used for k-NN indices")); } - - /** - * Plugin can provide additional node settings, that includes new settings or overrides for existing one from core. - * - * @return settings that are set by plugin - */ - @Override - public Settings additionalSettings() { - // We add engine specific extensions to the core list for HybridFS store type. We read existing values - // and append ours because in core setting will be replaced by override. - // Values are set as cluster defaults and are used at index creation time. Index specific overrides will take priority over values - // that are set here. - final List engineSettings = Arrays.stream(KNNEngine.values()) - .flatMap(engine -> engine.mmapFileExtensions().stream()) - .collect(Collectors.toList()); - final List combinedSettings = Stream.concat( - IndexModule.INDEX_STORE_HYBRID_MMAP_EXTENSIONS.getDefault(Settings.EMPTY).stream(), - engineSettings.stream() - ).collect(Collectors.toList()); - return Settings.builder().putList(IndexModule.INDEX_STORE_HYBRID_MMAP_EXTENSIONS.getKey(), combinedSettings).build(); - } }