Skip to content
This repository has been archived by the owner on Nov 23, 2022. It is now read-only.

Try to move external-types #656

Closed
7 of 19 tasks
DerMolly opened this issue Oct 9, 2020 · 2 comments
Closed
7 of 19 tasks

Try to move external-types #656

DerMolly opened this issue Oct 9, 2020 · 2 comments
Labels
priority: 2 medium Something needed by some users type: code quality enhancement An improvement to quality of code or config files
Milestone

Comments

@DerMolly
Copy link
Member

DerMolly commented Oct 9, 2020

We should try to move as much as possible from src/external-types to either the projects repos or DefinetlyTyped.

@DerMolly DerMolly added the type: code quality enhancement An improvement to quality of code or config files label Oct 9, 2020
@mrdrogdrog
Copy link
Member

mrdrogdrog commented Oct 13, 2020

Please be sure, that

  • Every PR includes EVERY possible type, signature and option! For our project it's okay to just use what we need. But if you provide these types to the original project then add everything. Otherwise they're useless because other devs have to complete them for their projects.
  • You use function instead of lambda consts, because this is something that only we do.

@mrdrogdrog mrdrogdrog added this to the Release 2.0 milestone Jan 18, 2021
@mrdrogdrog mrdrogdrog added the priority: 2 medium Something needed by some users label Jan 18, 2021
@DerMolly
Copy link
Member Author

Most of these were attempted, but many repos did adopt this unfortunatly

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: 2 medium Something needed by some users type: code quality enhancement An improvement to quality of code or config files
Projects
None yet
Development

No branches or pull requests

2 participants