Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support strings #192

Open
pearu opened this issue Sep 20, 2020 · 6 comments
Open

Support strings #192

pearu opened this issue Sep 20, 2020 · 6 comments
Assignees
Labels
enhancement New feature or request heavydb Related to heavydb server

Comments

@pearu
Copy link
Contributor

pearu commented Sep 20, 2020

Perhaps already have string dictionary support by inputting key_for_string, but could make nicer ux around this

@pearu
Copy link
Contributor Author

pearu commented Nov 17, 2020

See Slack discussions for ideas:

  1. https://quansight.slack.com/archives/C01CAU0U1FH/p1605526178096400

@guilhermeleobas
Copy link
Contributor

@guilhermeleobas
Copy link
Contributor

TextEncodingNone and TextEncodingDict types are supported.

@pearu
Copy link
Contributor Author

pearu commented Mar 31, 2022

Tests in rbc/tests/heavyai/test_text_encoding.py cover the cases where TextEncodingDict variables are passed around but we don't have tests for accessing the content of TextEncodingDict variables. In short, we should be able to define a UDF that translates a TextEncodingDict variable to TextEncodingNone return value, for instance. And vice-versa, checking if TextEncodingNone variable can be converted to TextEncodingDict return value (I imagine if the input string is not in the strings dictionary, the conversion should fail, or add a new item to the dict).

@guilhermeleobas
Copy link
Contributor

PR #531 adds support for python strings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request heavydb Related to heavydb server
Projects
None yet
Development

No branches or pull requests

2 participants