Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rmv warning from load_namespaces #926

Merged
merged 5 commits into from
Sep 3, 2023
Merged

rmv warning from load_namespaces #926

merged 5 commits into from
Sep 3, 2023

Conversation

bendichter
Copy link
Contributor

@bendichter bendichter commented Jul 31, 2023

Motivation

Remove warning that occurs when you try to load namespaces and there are none.

Addresses NeurodataWithoutBorders/pynwb#1748 (comment)

@bendichter bendichter requested a review from rly July 31, 2023 20:49
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (9fe3f9d) 88.47% compared to head (7f4299f) 88.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #926      +/-   ##
==========================================
- Coverage   88.47%   88.46%   -0.01%     
==========================================
  Files          45       45              
  Lines        9350     9346       -4     
  Branches     2663     2662       -1     
==========================================
- Hits         8272     8268       -4     
  Misses        761      761              
  Partials      317      317              
Files Changed Coverage Δ
src/hdmf/backends/hdf5/h5tools.py 82.48% <100.00%> (-0.08%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bendichter
Copy link
Contributor Author

@rly changing pynwb requires a change to hdmf and changing hdmf requires a change to pynwb. I'm not sure how to navigate this

rly
rly previously approved these changes Sep 3, 2023
@rly rly merged commit ddc842b into dev Sep 3, 2023
25 of 26 checks passed
@rly rly deleted the rmv_load_namespaces_warning branch September 3, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants