Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken nightly macos gallery min test #93

Merged
merged 2 commits into from
May 21, 2023
Merged

Fix broken nightly macos gallery min test #93

merged 2 commits into from
May 21, 2023

Conversation

rly
Copy link
Contributor

@rly rly commented May 21, 2023

Motivation

The nightly macos gallery python 3.7 minimum tests are broken due to a typo in the github actions workflow yaml

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly requested a review from oruebel May 21, 2023 06:05
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4207ca6) 81.94% compared to head (2243bdd) 81.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #93   +/-   ##
=======================================
  Coverage   81.94%   81.94%           
=======================================
  Files          11       11           
  Lines        2647     2647           
=======================================
  Hits         2169     2169           
  Misses        478      478           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oruebel oruebel merged commit 3c2bb12 into dev May 21, 2023
@oruebel oruebel deleted the rly-patch-1 branch May 21, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants