-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store object_id with links if available #57
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #57 +/- ##
==========================================
+ Coverage 85.66% 85.76% +0.09%
==========================================
Files 13 13
Lines 3139 3189 +50
==========================================
+ Hits 2689 2735 +46
- Misses 450 454 +4
☔ View full report in Codecov by Sentry. |
@mavaylon1 we should check whether this PR now also works with the fixes in #120 It would be nice we could include this in the release as well if it works. Otherwise, its fine to move this PR to the next release, but would be nice to push this over the finish line. |
Aside from adding/updating unit tests to check that the values for the |
Done |
@oruebel I wanted to as about the case when the object_id is None. You said that would be the case when the data_type/neuro_datatype is not assigned for a dataset. I was thinking of an example of what that would be. Say we have TimeSeries, which is a dataset. This has a type, but it also contains a dataset "data" that does not. This would be an example where we have "object_id" as none if that was the target correct? |
Correct. For |
Fix #54
This PR updates the storage of links/references to add the following information:
object_id
: Object id of the reference object. May be None in case the referenced object does not have and assigned object_id (e.g., in the case we reference a dataset with a fixed name but without and assigned data_type (or neurodata_type in the case of NWB).source_object_id
: Object id of the source Zarr file indicated by thesource
key. Thesource
should always have anobject_id
(at least if thesource
file is a valid HDMF formatted file).TODO:
ZarrReference
class to add asource_object_id
andobject_id
keysZARRIO.__get_ref
to populate thesource_object_id
andobject_id
keyssource_object_id
andobject_id
keys and update examples