Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save object id's as part of links and references #54

Closed
oruebel opened this issue Dec 22, 2022 · 2 comments · Fixed by #57
Closed

Save object id's as part of links and references #54

oruebel opened this issue Dec 22, 2022 · 2 comments · Fixed by #57
Assignees
Labels
category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of users
Milestone

Comments

@oruebel
Copy link
Contributor

oruebel commented Dec 22, 2022

  • To enhance portability of links and references it would be nice to store the object_id of the Zarr file in addition to the relative path when a link/reference points to an external file. This will be useful both for error checking but can also help resolve links in case that path's are not valid
@oruebel oruebel added category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of users labels Dec 22, 2022
@oruebel oruebel self-assigned this Dec 22, 2022
@oruebel
Copy link
Contributor Author

oruebel commented Dec 22, 2022

Implementing this will require:

@oruebel
Copy link
Contributor Author

oruebel commented Dec 24, 2022

#57 partially addresses this issue by storing the object_id of the referenced object itself if it is available. However, not all links may point to object with an assigned object_id, so there are cases where the object_id will be None.

Because of this, storing the object_id of the source Zarr file will be useful in addition as well. However, determining the object_id of the source is trickier because we only have the path of the source object and the builder of the referenced object. To determine the object_id of the source it seems that we would then either need to open the source Zarr file, or at least open the JSON file with the attributes of the source Zarr file. This approach is not ideal, as we should avoid opening other files during write. Alternatively, we may be able to trace the parents of the builder until we find the the root builder (i.e., the builder where builder.parent is None should be builder of the target Zarr file).

@oruebel oruebel added this to the Next Release milestone Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant