Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Endpoint to upload a file #18

Closed
MiguelMRojas opened this issue Oct 4, 2023 · 3 comments
Closed

feat: Endpoint to upload a file #18

MiguelMRojas opened this issue Oct 4, 2023 · 3 comments
Assignees
Labels
feature A new feature

Comments

@MiguelMRojas
Copy link
Member

No description provided.

@MiguelMRojas MiguelMRojas added the feature A new feature label Oct 4, 2023
@PedroChaparro PedroChaparro changed the title feat: Files endpoint feat: Endpoint to upload a file Oct 4, 2023
@PedroChaparro
Copy link
Contributor

@AndreaVelasquezA
Copy link
Member

Hi! I have a question, I am reviewing both API specifications (.NET and Python) and I want to confirm which fields this endpoint receives, I ask this because in the specifications it is handled in different ways.

upload_file fields
-file
-fileName
-location

Are these fields correct? or am I forgetting someone field?

@PedroChaparro
Copy link
Contributor

Are these fields correct? or am I forgetting someone field?

Hi 👋! Those fields are correct. You can check the updated specification in the dev branch. The problem is that, as you said, this specification is not fully compatible with the .net one, but that shouldn't be a problem if we manage to complete this proxy completely.

I'm doubting about the fileName field. If you're able to obtain the name from the file itself, feel free to remove the fileName field from the openapi specification.

Also, keep in mind that, right now, the endpoint expects the data to be sent in multipart/form-data instead of application/json, that's because using multipart/form-data you can send a file without encoding it in base64 or any other encoding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants