Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed transactions (where abitration ruled in favor of the XMR seller party) appear on the list of trades / transactions #943

Closed
nihilist001 opened this issue May 20, 2024 · 4 comments

Comments

@nihilist001
Copy link

nihilist001 commented May 20, 2024

I made sure that a trade failed and yet it appears on the list of trades, probably not the intended behavior, let me know if thats a valid concern:

image

image

In short, the buyer didn't buy anything in this case, he lost the security deposit, yet it still appears

@preland
Copy link
Contributor

preland commented May 22, 2024

To make this clear: does the current implementation imply that the transaction succeeded?

@nihilist001
Copy link
Author

To make this clear: does the current implementation imply that the transaction succeeded?

Yes, it shows up under the market > trades so i assume it should be only the successful trades

@preland
Copy link
Contributor

preland commented May 22, 2024

Yeah that probably isn’t right

What might be more pressing—on one of the pages is an option to export transactions to a CSV. I wonder if the failed trade shows up there 💀

@woodser
Copy link
Contributor

woodser commented May 26, 2024

Only successful trades are published in the 1.0.6 release: 14d1702

@woodser woodser closed this as completed May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants