Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add column with transaction fees (Funding > Transactions > Export CSV) [0.5 XMR] #1254

Closed
woodser opened this issue Sep 6, 2024 · 5 comments · Fixed by #1288
Closed

Add column with transaction fees (Funding > Transactions > Export CSV) [0.5 XMR] #1254

woodser opened this issue Sep 6, 2024 · 5 comments · Fixed by #1288
Labels
💰bounty There is a bounty on this issue is:feature Request for a new feature

Comments

@woodser
Copy link
Contributor

woodser commented Sep 6, 2024

This issue requests adding a column for transaction fees in the generated transaction report CSV.

To generate the transaction report, go to Funding > Transactions > Export CSV.

The report only has a column for the amount of XMR transacted.

The tx fee should also appear as a column in the Funds > Transactions tab.

@woodser woodser added the is:feature Request for a new feature label Sep 6, 2024
@woodser woodser changed the title Add column with transaction fees (Funding > Transactions > Export CSV) Add column with transaction fees (Funding > Transactions > Export CSV) [0.15 XMR] Sep 6, 2024
@woodser woodser added the 💰bounty There is a bounty on this issue label Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

There is a bounty on this issue, the amount is in the title. The reward will be awarded to the first person or group of people who resolves this issue.

If you are starting to work on this bounty, please write a comment, so that we can assign the issue to you. We expect contributors to provide a PR in a reasonable time frame or, in case of an extensive work, updates on their progresses. We will unassign the issue if we feel the assignee is not responsive or has abandoned the task.

Read the full conditions and details of our bounty system.

@woodser woodser changed the title Add column with transaction fees (Funding > Transactions > Export CSV) [0.15 XMR] Add column with transaction fees (Funding > Transactions > Export CSV) [0.2 XMR] Sep 6, 2024
@woodser woodser changed the title Add column with transaction fees (Funding > Transactions > Export CSV) [0.2 XMR] Add column with transaction fees (Funding > Transactions > Export CSV) [0.5 XMR] Sep 8, 2024
@preland
Copy link
Contributor

preland commented Sep 8, 2024

I'll start looking into this one

@niyid
Copy link
Contributor

niyid commented Sep 9, 2024

Is it OK to assume transaction fee = tx.getFee() in TransactionsListItem?

@niyid
Copy link
Contributor

niyid commented Sep 9, 2024

I'll start looking into this one

Oops, sorry. I put in a PR.

@woodser
Copy link
Contributor Author

woodser commented Sep 25, 2024

This issue is resolved with #1288

With this change, the total amounts in Funds > Transactions adds up to the total balance correctly.

I'll be awarding the bounty to @niyid because his submission was first and functional, while preland's submission has an error when run (and some unnecessary formatting changes :P). While neither submission was fully correct, niyid's submission was easily adapted to display the fee for outgoing transactions.

Thanks very much for your help. @niyid please message me an address for payment. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💰bounty There is a bounty on this issue is:feature Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants