Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of requests to poll a Monero daemon [$800] #110

Closed
erciccione opened this issue Sep 1, 2021 · 6 comments
Closed

Reduce the number of requests to poll a Monero daemon [$800] #110

erciccione opened this issue Sep 1, 2021 · 6 comments
Assignees
Labels
a:monero Changes related to Monero 💰bounty There is a bounty on this issue is:feature Request for a new feature P4 Scheduled task, but low priority

Comments

@erciccione
Copy link
Contributor

"Currently, wallets make up to 4 requests each time a wallet polls a daemon: get_info, get_transaction_pool_hashes, get_transactions, and get_blocks.bin.

As a result, daemons must service up to 4 requests for each client poll, and the user may experience a noticeable delay before their wallet even starts to sync blocks if their connection is slow."

See the issue on the Monero repo for the full details: monero-project/monero#7571

@erciccione erciccione added is:feature Request for a new feature P3 normal priority a:monero Changes related to Monero labels Sep 1, 2021
@erciccione erciccione changed the title Reduce the number of requests to poll a Monero daemon Reduce the number of requests to poll a Monero daemon [$800] Sep 11, 2021
@erciccione erciccione added the 💰bounty There is a bounty on this issue label Sep 11, 2021
@github-actions
Copy link

There is a bounty on this issue, the amount is in the title. The bounty will be awarded to the first person(s) who resolves this issue. Read the full conditions in the 'bounties.md' file. If you are starting to work on this issue, please write a comment here, so that we can assign the issue to you and avoid duplicated work.

@rbrunner7
Copy link

I will make a serious attempt to implement this, over the next 3 calendar weeks or so because working on spare time.

First looks into the existing code of the RPC calls to be replaced by this single new call and their use in wallet2 and simplewalletlet me suspect that closely working together with @woodser on the exact requirements will probably be a good idea.

@rbrunner7
Copy link

Thanks for the assignment!

A very first question: Where do I best place questions that I run into with this? Right here, or in some Haveno IRC / Matrix channel?

@erciccione
Copy link
Contributor Author

Thank you for working on this :)
The best place is #haveno-dev on IRC/Libera (#haveno-dev:haveno.network on Matrix)

@woodser
Copy link
Contributor

woodser commented Aug 18, 2023

This was merged into the release branch of monero-project with monero-project/monero#8800 by @rbrunner7.

@rbrunner7
Copy link

Thank you very much, @woodser, for paying out that bounty! Just received it.

It was nearly 2 years ago that I took on this work, and I am grateful that the bounty was honored nevertheless. I am also glad that I could made a small contribution towards making Haveno a success.

@woodser woodser closed this as completed Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:monero Changes related to Monero 💰bounty There is a bounty on this issue is:feature Request for a new feature P4 Scheduled task, but low priority
Projects
None yet
Development

No branches or pull requests

3 participants