Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] sync or push should continue after error #296

Open
clemenko opened this issue Aug 16, 2024 · 6 comments
Open

[feature] sync or push should continue after error #296

clemenko opened this issue Aug 16, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request priority/review

Comments

@clemenko
Copy link
Contributor

Is this RFE related to an Existing Problem? If so, please describe:

Customer is asking for the hauler sync or push functions continue after an error. Specifically from image pull that didn't work they want hauler to try and complete the rest of the list.

Describe Proposed Solution(s):

Have a flag that will try every item in the manifest.

Describe Possible Alternatives:

Retrying the sync/push until the one item completes.

Additional Context:

@clemenko clemenko added the enhancement New feature or request label Aug 16, 2024
@github-project-automation github-project-automation bot moved this to Pending Review in Hauler Aug 16, 2024
@zackbradys
Copy link
Member

Similar issue to Issue #284!

@ethanchowell
Copy link
Contributor

It's not so much the image pull or retries that are causing issues as it is the behavior when you try to hauler store copy to a registry with tag immutability configured. In those cases if one of N number of images exists in the target registry, hauler exits at that first failure leaving some number of images unable to push.

@zackbradys
Copy link
Member

Hey @ethanchowell... thanks for the additional information. We were discussing this a bit today and will continue to investigate how to address it. ECR is always tricky to work with...

@zackbradys
Copy link
Member

Hey @clemenko / @ethanchowell, we resolved one of the issues of continuing on error and maintaining the amount of retries, defaulted at three retries, with PR #317 and v1.0.8, but will keep this open as an Issue/RFE due to the fact we still need to address tag immutability.

@ethanchowell
Copy link
Contributor

I just tested 1.0.8 and I'm still observing the issue where when I run hauler store copy registry://<dest>, if one image fails, execution stops and no other images push. This isn't really related to ecr and it's mechanics around tag mutability, I only used that as an example because it's an easy one to validate. The bigger issue is that if I rely on hauler to an airgapped environment and try to upload those images, I'm dead in the water if one of those image uploads fails because the registry I'm pushing to doesn't allow overwriting images they already have. Looks like it's a result of the bulk write failing here

@zackbradys
Copy link
Member

partially similar to #323 and linked others...

@zackbradys zackbradys moved this from To Triage to In Progress in Hauler Nov 21, 2024
@zackbradys zackbradys self-assigned this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority/review
Projects
Status: In Progress
Development

No branches or pull requests

3 participants