Deprecated safeApprove() function

[hats-bug-reporter]

Github username: --
Submission hash (on-chain): 0x013b8f250b24421352d875f4e429ba781770429c144298172fc00cec16953930
Severity: low

Description:
Description

Using this deprecated function can lead to unintended reverts and potentially the locking of funds. A deeper discussion on the deprecation of this function is in OZ issue #2219 (OpenZeppelin/openzeppelin-contracts#2219). The OpenZeppelin ERC20 safeApprove() function has been deprecated, as seen in the comments of the OpenZeppelin code.

Attack Scenario
Describe how the vulnerability can be exploited.

Attachments

1. Proof of Concept (PoC) File

https://github.com/hats-finance/hats-contracts/blob/af0830ef3dccdb0e4bcf0e746147f252c98fd055/contracts/HATVaultsRegistry.sol#L449C36-L449C36

2. Revised Code File (Optional)

Always do safeApprove(0) if the allowance is being changed, or use safeIncreaseAllowance()

[jellegerbrandy]

This is a 3 yearhold issue on OZ that you are referring to, if OZ did not think of "fixing" it then neither do we