registerGroup function reverts when called with empty _name or _symbol

[hats-bug-reporter]

Github username: --
Twitter username: --
Submission hash (on-chain): 0xf98ccef9fe87ce0039b45e0f99fc036ca44aec603eb8b9c098d35e788625192f
Severity: medium

Description:
Description
The registerGroup function reverts when called with empty _name or empty _symbol.

This is due to the below checks in the internal _registerGroup function:

Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf/src/hub/Hub.sol

Lines 1017 to 1026 in 507e185

	if (!nameRegistry.isValidName(_name)) {
	// Invalid group name.
	// name must be ASCII alphanumeric and some special characters
	revert CirclesInvalidString(_name, 0);
	}
	if (!nameRegistry.isValidSymbol(_symbol)) {
	// Invalid group symbol.
	// symbol must be ASCII alphanumeric and some special characters
	revert CirclesInvalidString(_symbol, 1);
	}

These functions return false due to nameBytes.length == 0

Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf/src/names/NameRegistry.sol

Line 224 in 507e185

if (nameBytes.length > 32 || nameBytes.length == 0) return false; // Check length

Thus the internal _registerGroup function will revert with CirclesInvalidString error

This behaviour differs from the intended functionality of defaulting name to "Circles-<base58(short)Name> when _name is left empty.

Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf/src/names/NameRegistry.sol

Line 117 in 507e185

// if name is left empty, it will default to default name "Circles-<base58(short)Name>"

This is a medium issue because it results in essential functionality of the contracts being temporarily unusable or inaccessible.

Recommendation
Replace the

 if (nameBytes.length > 32 || nameBytes.length == 0) return false; // Check length

condition in isValidName function with

 if (nameBytes.length > 32 return false; // Check length

There is no need to return false on nameBytes.length == 0

[benjaminbollen]

Groups must have a valid custom name, organizations do not.