Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a new round 1 should not bring in duplicate files #237

Open
CiellB opened this issue Oct 10, 2024 · 3 comments
Open

Creating a new round 1 should not bring in duplicate files #237

CiellB opened this issue Oct 10, 2024 · 3 comments

Comments

@CiellB
Copy link

CiellB commented Oct 10, 2024

Problem:
Campaign coordinators sometimes discover an error in their activated round 1.
They delete the first round 1 and create a second round 1. Montage then pulls in the same set of images a second time, and with that creates the same tasks a second time, thus doubling up on everything. Jurors then also get double the amount of tasks assigned.
The only solution I have currently, is to create a new campaign for them.

Expected behavior:
If a file is already in the campaign, Montage should skip adding it a second time.
or
Montage should also delete the files and tasks originally created when the initial round 1 is deleted.
or
As campaign creator I could have the rights to reset these settings for the campaign coordinator.

@mahmoud
Copy link
Member

mahmoud commented Oct 10, 2024

If I'm understanding correctly, the new round has duplicate images in it? Montage is designed to prevent that: Deleting a round also deactivates the tasks. A new round has a new ID and new tasks. There are several uniqueness constraints in the database to prevent this. I believe this has been done hundreds of times without issue for years now, including in tests.

Please try to reproduce this with a test campaign to see if there's been a regression and link it here. Also link any campaigns where this has occurred That way, I can look at the audit log for more details.

My only guess right now is that this is an occasional misbehavior affecting large rounds, due to timeouts and Toolforge's non-transactional database settings.

@CiellB
Copy link
Author

CiellB commented Oct 10, 2024

Hmm, it has happened a few times over the past years, but not recently (maybe also because now I just create a new campaign.)
Let me see if I have time over the weekend or next week to find you some examples.

@CiellB
Copy link
Author

CiellB commented Oct 10, 2024

The cases where I had to offer a new campaign because of double task creation were explicitly when there were multiple first round created. It does not seem to happen with subsequent rounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants