Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows build fix for some mingw gnu make situations #1870

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Windows build fix for some mingw gnu make situations #1870

merged 2 commits into from
Jan 30, 2023

Commits on Jan 22, 2023

  1. When tools/top.mk finds it is running on Windows, it expects SHELL se…

    …t to cmd.exe.
    
    Some Windows development environments invoke a mingw version of gnu make
    with SHELL set to /bin/sh or /bin/bash (either explicitly or by default),
    in which case tinyUSB make fails when a $(shell...) command feeds DOS syntax to sh.
    We can't just use sh, as many Windows environments won't have unix utilities
    like realpath (used by this makefile for sh shell commands).
    
    This fix forces SHELL=cmd.exe on Windows and documents the issue.
    Also adds additional documentation to help the next person...
    
    With this fix, tinyUSB can be easily built and debugged in environments like
    NXP's MCUxpresso (import as a makefile project).
    DRNadler committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    9b6ef4f View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. minor clean up

    hathach committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    39eb1ce View commit details
    Browse the repository at this point in the history