da1469x: fix resume #1291
Merged
da1469x: fix resume #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bit mask enabling/disabling over-run/unde-run was shifted by one nibble, so interrupt was never enabled. It did not force any issue as this situation could only happen on ISO endpoints without DMA.
hathach
reviewed
Jan 20, 2022
| for (int epnum = 1; epnum <= 3; ++epnum) | ||
| { | ||
| xfer_ctl_t * xfer = XFER_CTL_BASE(epnum, TUSB_DIR_OUT); | ||
| if (xfer->total_len > xfer->transferred) |
There was a problem hiding this comment.
Could you have the simple if in one line or use bracket for it. I know this style is common in Linux, but it is rather error-prone.
Going to suspend states disable reception on non-0 RX endpoints. Now when USB resume condition is detected, all RX endpoints with pending transfers are resumed.
kasjer
force-pushed
the
kasjer/da1469x-fix-resume
branch
from
fd76d9d
to
7b07836
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Entering suspend mode clears bit USB_RX_EN in USB_RXCx_REG.
Resuming after suspend state did not enable reception on non-0 endpoints.
It resulted in incoming packets being NAK'ed after resume.
Now, on resume event, all OUT endpoints are checked for pending transfers
and when transfer is not completed USB_RX_EN bit is set by start_tx_packet.
Additionally over-run/under-run masks were off by 4 bits so those interrupts
would never be enabled.