general update + ability to set dns servers to use #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. eslint + linting code 3. npm test fixed (commented out lists not working) 4. add function `.setServers` to set custom DNS server being used for resolve. .addServers is important, because in docker, this package hits rate limit moby/libnetwork#2082 moby/libnetwork#2214
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for good library.
But when i try to start it on nodejs project working in docker container, i got rate limit errors because of this
moby/libnetwork#2214
moby/libnetwork#2082
by default, nodejs uses default docker resolver (172.0.0.11) as described here
https://docs.docker.com/v17.09/engine/userguide/networking/configure-dns/
but this resolver has only 100 connections per second limit.
When i try to check domains by your library, it fails.
To be able to check with good speed, i use custom DNS servers.
and my PR allows us to add this servers via
.setServersexported function.also i fixed tests, updated code, integrated eslint, edtor config and so on.
Tests, of course, pass.