Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: caching is likely broken #320

Open
andreasabel opened this issue May 3, 2024 · 3 comments
Open

CI: caching is likely broken #320

andreasabel opened this issue May 3, 2024 · 3 comments

Comments

@andreasabel
Copy link
Member

CI caches are likely stale (most are from 2023):
Screenshot 2024-05-03 at 20 05 03
A more flexible cache key is needed, either involving github.sha or a hash of the build plan in dist-newstyle/cache/plan.json (create with cabal build ... --dry-run).

Also due to XDG it could be that the wrong directory is cached now (but this would not matter since the restored caches are anyway hopelessly outdated):

- uses: actions/cache@v4
name: Cache cabal stuff
with:
path: |
~/.cabal/store

@hasufell
Copy link
Member

Can you provide a PR? I feel kinda lazy about this.

@andreasabel
Copy link
Member Author

andreasabel commented Jun 27, 2024

How would you sort out the XDG issue?
I don't feel like reproducing cabal's XDG logic in each CI. Figuring out the cabal store shouldn't involve hand-knitted code. So either delegate it to haskell-action/setup, or a future cabal that can print the store path, or switch off the XDG logic by creating a .cabal/config before installing cabal. Or, use some action (TM) that sets the XDG_* variables suitable for the OS (and is compatible with cabal's choices).

@hasufell
Copy link
Member

Just set CABAL_DIR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants