-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap genShortByteString for genByteArray #142
Comments
I had the same idea the moment you released the
I don't think this is terribly important, in fat I'd be against it, especially considering that That being said, I do agree with you 100% requiring in genByteArray :: Int -> g -> (ByteArray, g) instead of random/src/System/Random/Internal.hs Line 183 in 632b64e
and uniformByteArray :: Int -> g -> m ByteArray instead of random/src/System/Random/Internal.hs Line 282 in 632b64e
in Makes a lot of sense.
|
+1 for switching to |
Since
bytestring-0.12
ShortByteString
is just a newtype overByteArray
, a common data type shared bybase
,text
andprimitive
.I think we can make
class Random
more useful if we swapThis way we can shave off dependency on
bytestring
and do not impose it on our users.There does not seem to be many users of
genShortByteString
in the wild. Potentially we can provide a compatibility shim:The text was updated successfully, but these errors were encountered: