Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is unpackFamily deprecated? #324

Closed
chris-martin opened this issue May 28, 2018 · 4 comments
Closed

Why is unpackFamily deprecated? #324

chris-martin opened this issue May 28, 2018 · 4 comments

Comments

@chris-martin
Copy link
Contributor

There are a few deprecation warnings here that are missing some documentation - 2156c61 and 655e2f5 - Why are they deprecated, what's wrong with them, and what should we use instead?

In particular, I'm wondering what we'll need to do to upgrade https://github.com/ddfisher/haskell-socket-activation/blob/db6a14da89aa7a5411063303a820d7bde601e665/Network/Socket/Activation.hs#L45

@kazu-yamamoto
Copy link
Collaborator

In 3.0, both packFamily and unpackPack still exist with the same signatures internally. So, I think we can export them in 3.0 and delete the deprecation pragmas from 2.7.

If there are any other such APIs, please let me know. I will fix them in 2.7.0.1.

@kazu-yamamoto kazu-yamamoto mentioned this issue May 29, 2018
5 tasks
@chris-martin
Copy link
Contributor Author

Thanks. The other deprecation warning I'm looking at is SocketStatus. ddfisher/haskell-socket-activation#5 (comment)

@kazu-yamamoto
Copy link
Collaborator

The definition of Socket in 3.0 is:

data Socket = Socket (IORef CInt) CInt {- for Show -}

So, we will not have status of sockets.

kazu-yamamoto added a commit to kazu-yamamoto/network that referenced this issue May 29, 2018
@kazu-yamamoto
Copy link
Collaborator

Done.
Thank you for your report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants