Allow a control message to contain multiple file descriptors (issue #566) #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…askell#566) ControlMessage has lost the Storable constraint, because it is not possible to implement Storable [Fd] because [Fd] is not fixed-size when encoded.
Dretch
commented
Jul 29, 2023
| @@ -231,7 +231,7 @@ sendManyWithFds s bss fds = | |||
| sendBufMsg s addr bufsizs cmsgs flags | |||
| where | |||
| addr = NullSockAddr | |||
| cmsgs = encodeCmsg <$> fds | |||
| cmsgs = encodeCmsg . (:[]) <$> fds | |||
There was a problem hiding this comment.
This could now send all the file descriptors in a single Cmsg, but I left it this way to avoid changing the current behaviour.
Dretch
commented
Jul 29, 2023
| Nothing -> return (-1) | ||
| Just (Fd fd) -> return fd | ||
| case (lookupCmsg CmsgIdFds cmsgs >>= decodeCmsg) :: Maybe [Fd] of | ||
| Just (Fd fd : _) -> return fd |
There was a problem hiding this comment.
Same behaviour as before: take the first Fd and ignore the others.
|
I'm using this code now to see what happens in my projects. |
kazu-yamamoto
approved these changes
Aug 7, 2023
|
Looks like this PR broke the Windows build: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ControlMessage has lost the Storable constraint, because it is not possible to implement Storable [Fd] because [Fd] is not fixed-size when encoded.