Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

making IPv4PktInfo on Win the same as that on Posix #522

Merged
merged 2 commits into from
Jan 18, 2022
Merged

making IPv4PktInfo on Win the same as that on Posix #522

merged 2 commits into from
Jan 18, 2022

Conversation

kazu-yamamoto
Copy link
Collaborator

This should fix #519.

@kazu-yamamoto kazu-yamamoto requested a review from Mistuke January 18, 2022 02:00
Mistuke
Mistuke previously approved these changes Jan 18, 2022
View reviewed changes
Copy link
Collaborator

@Mistuke Mistuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! I would appreciate a comment on the divergent struct though.

@kazu-yamamoto kazu-yamamoto merged commit e11132d into haskell:master Jan 18, 2022
@kazu-yamamoto kazu-yamamoto deleted the fix-win-pktinfo branch January 18, 2022 23:35
@kazu-yamamoto
Copy link
Collaborator Author

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mistuke Mistuke Mistuke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IP_PKTINFO
2 participants
@kazu-yamamoto @Mistuke