Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Language.Haskell.LSP.Messages into haskell-lsp-types #159

Closed
lukel97 opened this issue Apr 28, 2019 · 3 comments
Closed

Move Language.Haskell.LSP.Messages into haskell-lsp-types #159

lukel97 opened this issue Apr 28, 2019 · 3 comments

Comments

@lukel97
Copy link
Collaborator

lukel97 commented Apr 28, 2019

No description provided.

@lukel97
Copy link
Collaborator Author

lukel97 commented Apr 29, 2019

@alanz after thinking about this for a bit, I think the reason why it was not originally moved into haskell-lsp-types might have been that the wrapper types inside Language.Haskell.LSP.Messages aren't strictly a part of the LSP specification. They're types used only by haskell-lsp. Does it then make sense to leave them as a part of haskell-lsp? Or is it ok/used widely enough to consider moving into haskell-lsp-types?

@alanz
Copy link
Collaborator

alanz commented Apr 29, 2019

Well, one argument is that the messages are part of the types.

My primary motivation for splitting them was to put all the TH stuff in a separate package that changed rarely, so working on haskell-lsp was not so achingly slow.

So using that criterion it should probably be called haskell-lsp-th-types, and we should try to limit them to that.

@wz1000
Copy link
Collaborator

wz1000 commented Oct 15, 2020

Invalidated by #244

@wz1000 wz1000 closed this as completed Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants