Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell-doc-mode is not asynchronous wrt ghci process, unlike eldoc-mode #649

Closed
ikirill opened this issue May 13, 2015 · 4 comments
Closed

Comments

@ikirill
Copy link
Contributor

ikirill commented May 13, 2015

haskell-mode's support for eldoc-mode is asynchronous, so placing point on top of an expression while a ghci computation is already running does not hang emacs. On the contrary, haskell-doc-mode runs the :type command synchronously, possibly hanging emacs when point is moved until the corresponding ghci command is executed.

https://github.com/haskell/haskell-mode/blob/master/haskell-doc.el#L1570

https://github.com/haskell/haskell-mode/blob/master/haskell-doc.el#L1517

@gracjan
Copy link
Contributor

gracjan commented May 15, 2015

Good catch. There were recent changes that solved a similar issue in #607.

@ikirill
Copy link
Contributor Author

ikirill commented May 15, 2015

One thing about it is that haskell-doc-mode is quite old, IIUC, and seems to be duplicating what the standard eldoc-mode is doing anyway. Since eldoc-mode is included with emacs, would it be reasonable to deprecate haskell-doc-mode and move to only using eldoc-mode? In my configuration I turned it off when it started giving me this problem.

@gracjan
Copy link
Contributor

gracjan commented May 16, 2015

@ikirill: Can you research this topic?

If there is a standard way to provide a functionality then it is usually better to use it. On the other hand we would like to avoid upsetting our users by breaking something they liked.

@gracjan
Copy link
Contributor

gracjan commented Feb 22, 2016

We will not be fixing haskell-doc-mode, we will work on eldoc-mode support instead.

@gracjan gracjan closed this as completed Feb 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants