Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with column-enforce-mode and long literate (latex-style) comments #331

Closed
listx opened this issue Sep 2, 2014 · 4 comments

Comments

@listx
Copy link

listx commented Sep 2, 2014

column-enforce-mode (https://github.com/jordonbiondo/column-enforce-mode) is a minor mode that highlights long lines (starting with the 80th column).

As of today, column-enforce-mode has a new feature variable called column-enforce-comments that disables highlighting long lines if they are comment lines. From what I can tell, haskell-mode has a caching mechanism for applying font-lock-comment-face (in haskell-fl-latex-comments) and column-enforce-comments does not work reliably with it (sometimes it highlights long comment lines, sometimes it doesn't --- all within the same file).

Is there a way to fix this?

@gracjan gracjan changed the title compatibility with column-enforce-mode and long literate (latex-style) comments Compatibility with column-enforce-mode and long literate (latex-style) comments Mar 9, 2015
@gracjan
Copy link
Contributor

gracjan commented Feb 13, 2016

@listx: I know this is an old issue, but could you create a test case in tests/haskell-font-lock-tests.el? Thanks.

@listx
Copy link
Author

listx commented Feb 16, 2016

Between work and my other projects I do not have the time to learn how the test suite works, and to add a test case for it. Sorry!

FWIW the issue is still relevant.

@gracjan
Copy link
Contributor

gracjan commented Feb 16, 2016

Note that we have changed significantly how comments are marked in Latex sources. It used to use start and and of comment, right now it is per line. Can you check if the issue really persist after #1050 got merged?

@listx
Copy link
Author

listx commented Feb 18, 2016

So, my last comment stating that the issue still persists was in error. Since the time of the original report, I had moved to MMM (Multiple Major Modes) and had enabled LaTeX mode for the latex-style comment regions. For some reason I had equated the long-line highlighting within the LaTeX mode (not literate-haskell-mode) parts with this bug report.

Simply enabling literate-haskell-mode only reveals that indeed this issue has been fixed (probably after #1050 got merged as you suggested). The long lines in the latex-style comment blocks do not get highlighted by column-enforce-mode for me.

Thanks @gracjan for the tip

@listx listx closed this as completed Feb 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants