Call useWithStale instead of useWithStaleFast when calling ParseCabalFields #4294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't seem right to me. I thought completions were one of the typical examples where we definitely want fast response speed at the expense of stale output? |
VeryMilkyJoe
force-pushed
the
cabal-completions-fix
branch
from
6763217 to
be9c5f8
Compare
VeryMilkyJoe
changed the title
VeryMilkyJoe
force-pushed
the
cabal-completions-fix
branch
2 times, most recently
from
0412b6f to
5888db8
Compare
…Fields Add documentation about this choice
VeryMilkyJoe
force-pushed
the
cabal-completions-fix
branch
from
5888db8 to
c17d320
Compare
|
In general true, but |
fendor
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds some documentation about why we use each of these versions of
use.Fixes #4293.