Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EKG #4163

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Remove EKG #4163

merged 1 commit into from
Apr 7, 2024

Conversation

michaelpj
Copy link
Collaborator

It's always been a pain and it's not really used.

Fixes #3993

It's always been a pain and it's not really used.

Fixes #3993
@michaelpj michaelpj requested a review from fendor April 6, 2024 21:22
@michaelpj michaelpj requested a review from pepeiborra as a code owner April 6, 2024 21:22
@soulomoon soulomoon self-requested a review April 7, 2024 02:39
Copy link
Collaborator

@soulomoon soulomoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am a bit sad, because I think these monitors are interesting in itself, but I cant say I have used them.

@michaelpj
Copy link
Collaborator Author

Yes, I think it's a good idea, but the interface is still there if we want to resurrect it. And the EKG library has been nothing but a pain.

@fendor fendor merged commit 334b4d4 into master Apr 7, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove EKG from ghcide
3 participants