Fix -Wall in qualified imported names plugin #4070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrcek
commented
Feb 12, 2024
| @@ -111,7 +110,7 @@ data ImportedBy = ImportedBy { | |||
| } | |||
|
|
|||
| isRangeWithinImportedBy :: Range -> ImportedBy -> Bool | |||
| isRangeWithinImportedBy range (ImportedBy _ srcSpan) = fromMaybe False $ spanContainsRange srcSpan range | |||
| isRangeWithinImportedBy range ImportedBy{importedBySrcSpan} = fromMaybe False $ spanContainsRange importedBySrcSpan range | |||
There was a problem hiding this comment.
Agree that using named field puns could be controversial, I'm just fixing warnings of the type
Defined but not used: ‘importedBySrcSpan’
Other ways to make this go away:
- prefix record selectors in data type definition with _
- use the record selectors (e.g.
importedBySrcSpan ib) in function body
Also agree that these are inconsequential warnings, but I'm really close to fixing all the warnings/enabling pedantic flag everywhere and don't want to disable warnings selectively just because these last few small things 😄
There was a problem hiding this comment.
I think it is fine, and I don't think we have any policy regarding NamedFieldPuns.
fendor
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.