Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hls-cabal-fmt-plugin: Use the file contents of the LSP request #3776

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

fendor
Copy link
Collaborator

@fendor fendor commented Aug 25, 2023

Reported in haskell/vscode-haskell#945

The fix is basic: don't read from disk.

Copy link
Collaborator

@joyfulmantis joyfulmantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fendor fendor changed the title Use the file contents from the LSP request hls-cabal-fmt-plugin: Use the file contents of the LSP request Aug 25, 2023
Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof yes

@michaelpj michaelpj enabled auto-merge (squash) August 25, 2023 16:23
@fendor fendor force-pushed the fix/cabal-fmt-vfs branch 2 times, most recently from 87aabb3 to 7dfcfdb Compare August 25, 2023 17:27
@fendor fendor force-pushed the fix/cabal-fmt-vfs branch from 7dfcfdb to 6bbdb04 Compare August 25, 2023 18:21
@fendor fendor force-pushed the fix/cabal-fmt-vfs branch from 6bbdb04 to 166b387 Compare August 25, 2023 20:45
@michaelpj michaelpj merged commit 663c0e7 into haskell:master Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants