Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Show instance #2802

Merged
merged 6 commits into from
Apr 17, 2022
Merged

Fix Show instance #2802

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2adc4bf
Fix Show instance
pepeiborra Mar 26, 2022
1621dee
include fullModSummary
pepeiborra Mar 29, 2022
b3eab08
Merge branch 'master' into fix-show-instance
pepeiborra Apr 2, 2022
c9802ef
Merge branch 'master' into fix-show-instance
pepeiborra Apr 7, 2022
97d5398
Merge branch 'master' into fix-show-instance
wz1000 Apr 16, 2022
a62f67b
Merge branch 'master' into fix-show-instance
pepeiborra Apr 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ghcide/src/Development/IDE/Core/RuleTypes.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,11 @@ newtype GhcSessionDeps = GhcSessionDeps_
-- Required for interactive evaluation, but leads to more cache invalidations
fullModSummary :: Bool
}
deriving newtype (Eq, Show, Typeable, Hashable, NFData)
deriving newtype (Eq, Typeable, Hashable, NFData)

instance Show GhcSessionDeps where
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's wrong with the derived one? Worth a comment.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It prints True or False instead of the key name

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that the deriving strategy is new type instead of stock

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So why not use the stock deriving?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh the stock instance is very verbose and bloats traces. I have changed the custom instance to not ignore the boolean for good measure.

show (GhcSessionDeps_ False) = "GhcSessionDeps"
show (GhcSessionDeps_ True) = "GhcSessionDepsFull"

pattern GhcSessionDeps :: GhcSessionDeps
pattern GhcSessionDeps = GhcSessionDeps_ False
Expand Down