Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate custom source tarball #2248

Merged
merged 6 commits into from
Oct 5, 2021
Merged

Conversation

jneira
Copy link
Member

@jneira jneira commented Sep 29, 2021

  • autogenerated and would depend on github not messing with the tarball layout (they did so at least twice) for the hash to be stable
  • depend on the tag (yeah, if you force push, the hash changes too)
  • have bad tarball names like 1.4.0.tar.gz, causing trouble for ghcup

//cc @hasufell

@jneira
Copy link
Member Author

jneira commented Sep 30, 2021

would be the tarball suitable to be used in ghcup, @hasufell?

@jneira
Copy link
Member Author

jneira commented Sep 30, 2021

/rerun-workflow Testing

@hasufell
Copy link
Member

would be the tarball suitable to be used in ghcup, @hasufell?

yes

@jneira
Copy link
Member Author

jneira commented Oct 1, 2021

@pepeiborra i've used j1 for cabal in this one to see it alliviates the failing test suites (eval and tactics plugin)

@jneira
Copy link
Member Author

jneira commented Oct 1, 2021

it seems cabal -j1 is doing its job 😅

@jneira
Copy link
Member Author

jneira commented Oct 1, 2021

Now circleci is being unreliable 😢 random errors like

Starting container alanz/haskell-hie-ci
Warning: No authentication provided, using CircleCI credentials for pulls from Docker Hub.
  image cache not found on this host, downloading alanz/haskell-hie-ci
latest: Pulling from alanz/haskell-hie-ci

5667fdb72017: Pulling fs layer 
d83811f270d5: Pulling fs layer 
ee671aafb583: Pulling fs layer 
7fc152dfb3a6: Pulling fs layer 
a7fd29ca5a80: Pulling fs layer 
4259c72c0fea: Pulling fs layer 
49b7b3b4087d: Pulling fs layer 
3b6f3e77d5df: Pulling fs layer 
bd1cdac5be8f: Pulling fs layer 
e73abc6cb19b: Pulling fs layer 
7b07edcbba2f: Pulling fs layer 
357c6aebab42: Pulling fs layer 
510dee417fa0: Pulling fs layer 
6c84755500bd: Pulling fs layer 
510dee417fa0: Extracting [>                                                  ]  1.671MB/97.59MBB
  Error pulling image alanz/haskell-hie-ci: context deadline exceeded... retrying
  image cache not found on this host, downloading alanz/haskell-hie-ci
latest: Pulling from alanz/haskell-hie-ci

5667fdb72017: Pulling fs layer 
d83811f270d5: Pulling fs layer 
ee671aafb583: Pulling fs layer 
7fc152dfb3a6: Pulling fs layer 
a7fd29ca5a80: Pulling fs layer 
4259c72c0fea: Pulling fs layer 
49b7b3b4087d: Pulling fs layer 
3b6f3e77d5df: Pulling fs layer 
bd1cdac5be8f: Pulling fs layer 
e73abc6cb19b: Pulling fs layer 
7b07edcbba2f: Pulling fs layer 
357c6aebab42: Pulling fs layer 
510dee417fa0: Pulling fs layer 
6c84755500bd: Pulling fs layer 
4c919008f6f2: Extracting [================>                                  ]  27.85MB/83.46MBB

context deadline exceeded

@jneira
Copy link
Member Author

jneira commented Oct 1, 2021

@pepeiborra could you stamp the pr to merge the ci fix in master and unblock olther ones? thanks!

@jneira
Copy link
Member Author

jneira commented Oct 1, 2021

i was too optimistic 😢

 9 out of 39 tests failed (109.22s)

for tactics, windows and ghc-8.10.7

@jneira
Copy link
Member Author

jneira commented Oct 1, 2021

I still want to believe the -j1 is alliviating somewhat the issue

@jneira
Copy link
Member Author

jneira commented Oct 1, 2021

tactics + windows + 8.10.7 still resists:

 1 out of 8 tests failed (27.39s)
Test suite tests: FAIL

@jneira
Copy link
Member Author

jneira commented Oct 1, 2021

last fails for tactics:

2021-10-01T17:29:13.3775674Z �[0mFAIL (3.07s)
2021-10-01T17:29:13.3776143Z         uncaught exception: ErrorCall
2021-10-01T17:29:13.3776582Z         []
2021-10-01T17:29:13.3777036Z         CallStack (from HasCallStack):
2021-10-01T17:29:13.3777642Z           error, called at test\Utils.hs:128:14 in main:Utils
2021-10-01T17:29:13.3778371Z         Use -p '/GoldenListFmap (golden)/' to rerun this test only.
............
2021-10-01T17:29:17.9419793Z �[0mFAIL (2.37s)
2021-10-01T17:29:17.9420304Z         uncaught exception: ErrorCall
2021-10-01T17:29:17.9420789Z         []
2021-10-01T17:29:17.9421265Z         CallStack (from HasCallStack):
2021-10-01T17:29:17.9421929Z           error, called at test\Utils.hs:128:14 in main:Utils
2021-10-01T17:29:17.9422610Z         Use -p '/AutoZip (golden)/' to rerun this test only.

@jneira
Copy link
Member Author

jneira commented Oct 4, 2021

some stamp for this one @Ailrun @pepeiborra @michaelpj? thanks!

Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@jneira jneira added the merge me Label to trigger pull request merge label Oct 4, 2021
@mergify mergify bot merged commit 8ee73d0 into haskell:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create proper source tarballs in CI/on releases
3 participants