From aa5132dc4ad2df4782d835019ee4432c68eda276 Mon Sep 17 00:00:00 2001 From: Pepe Iborra Date: Sun, 25 Jul 2021 10:32:51 +0100 Subject: [PATCH 1/2] disable refinement hole fits --- ghcide/src/Development/IDE/GHC/Compat.hs | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/ghcide/src/Development/IDE/GHC/Compat.hs b/ghcide/src/Development/IDE/GHC/Compat.hs index 0bc0204821..5c4c3095a5 100644 --- a/ghcide/src/Development/IDE/GHC/Compat.hs +++ b/ghcide/src/Development/IDE/GHC/Compat.hs @@ -295,7 +295,7 @@ setUpTypedHoles df #if MIN_VERSION_ghc(8,8,0) $ flip gopt_unset Opt_ShowDocsOfHoleFits -- not used #endif - $ flip gopt_unset Opt_ShowMatchesOfHoleFits -- nice but broken (forgets module qualifiers) + $ flip gopt_unset Opt_ShowMatchesOfHoleFits -- nice but not used $ flip gopt_unset Opt_ShowProvOfHoleFits -- not used $ flip gopt_unset Opt_ShowTypeAppOfHoleFits -- not used $ flip gopt_unset Opt_ShowTypeAppVarsOfHoleFits -- not used @@ -303,11 +303,7 @@ setUpTypedHoles df $ flip gopt_set Opt_SortBySubsumHoleFits -- very nice and fast enough in most cases $ flip gopt_unset Opt_SortValidHoleFits $ flip gopt_unset Opt_UnclutterValidHoleFits - $ df - { refLevelHoleFits = Just 1 -- becomes slow at higher levels - , maxRefHoleFits = Just 10 -- quantity does not impact speed - , maxValidHoleFits = Nothing -- quantity does not impact speed - } + df nameListFromAvails :: [AvailInfo] -> [(SrcSpan, Name)] From b1e0689777d7da594b1537247ac1a6d064c1ecbb Mon Sep 17 00:00:00 2001 From: Pepe Iborra Date: Mon, 26 Jul 2021 19:55:30 +0100 Subject: [PATCH 2/2] hlint --- ghcide/src/Development/IDE/GHC/Compat.hs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ghcide/src/Development/IDE/GHC/Compat.hs b/ghcide/src/Development/IDE/GHC/Compat.hs index 5c4c3095a5..51e4ec9e68 100644 --- a/ghcide/src/Development/IDE/GHC/Compat.hs +++ b/ghcide/src/Development/IDE/GHC/Compat.hs @@ -302,8 +302,7 @@ setUpTypedHoles df $ flip gopt_unset Opt_ShowTypeOfHoleFits -- massively simplifies parsing $ flip gopt_set Opt_SortBySubsumHoleFits -- very nice and fast enough in most cases $ flip gopt_unset Opt_SortValidHoleFits - $ flip gopt_unset Opt_UnclutterValidHoleFits - df + $ gopt_unset df Opt_UnclutterValidHoleFits nameListFromAvails :: [AvailInfo] -> [(SrcSpan, Name)]