Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete the No- variants of language extensions and Strict extension #1238

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

mrBliss
Copy link
Contributor

@mrBliss mrBliss commented Jan 20, 2021

Fixes #1187.

Separate the list of pragmas used for completion from the list of pragmas used
to suggest enabling a language extension to fix an error. The former now include
the No- variants of the language extensions, e.g., NoDuplicateRecordFields.

@Ailrun Ailrun changed the title Complete the No- variants of language extensions Complete the No- variants of language extensions and Strict extension Jan 20, 2021
Fixes haskell#1187.

Separate the list of pragmas used for completion from the list of pragmas used
to suggest enabling a language extension to fix an error. The former now include
the `No-` variants of the language extensions, e.g., `NoDuplicateRecordFields`.
@mrBliss mrBliss force-pushed the mrBliss/complete-no-extensions branch from f34b8a7 to 8f58652 Compare January 20, 2021 14:27
Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, Thanks!

@Ailrun Ailrun added the merge me Label to trigger pull request merge label Jan 20, 2021
@mergify mergify bot merged commit 50854ca into haskell:master Jan 20, 2021
@mrBliss mrBliss deleted the mrBliss/complete-no-extensions branch January 20, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completion for negative language unextensions, i.e. NoDuplicateRecordFields
2 participants