Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch module outline to useWtihStale #1189

Merged
merged 2 commits into from
Jan 10, 2021
Merged

Switch module outline to useWtihStale #1189

merged 2 commits into from
Jan 10, 2021

Conversation

pepeiborra
Copy link
Collaborator

@pepeiborra pepeiborra commented Jan 10, 2021

Module outline is not a good fit for useWithStaleFast, changing branches should not break document outlines permanently (until edited again).

The problem here is that there is no way for the user to refresh the module outline, unlike completions, hovers, etc.

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks for the fix

@pepeiborra pepeiborra added the merge me Label to trigger pull request merge label Jan 10, 2021
@mergify mergify bot merged commit 5433723 into master Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants