-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add performance regression tests and benchmarks #807
Comments
Would be good to include benchmarks, which might be things that run for infeasibly long to include in tests, but are great at measuring and improving things in the region of 5% or less. |
Copying over @pepeiborra's comment:
I looked at this a bit. I think testing on real world workloads may be very important, since otherwise we can't capture all the nuances of what is being watched via notifications etc. |
@mpardalos - do you have plans to do this over the summer? It’s sorely needed! |
@pepeiborra Yes! I am planning on recording some sessions for this reason. I was planning on using lsp-test to run those sessions. I spoke with my GSoC mentor about this (@mpickering) and he told me that apparently lsp-test currently has problems with replaying sessions (it doesn't respect request timings) which might be a blocker for now? I couldn't find the relevant issue there so he probably has a better idea of what the problem is. |
I'm working on a simple benchmark based on https://neilmitchell.blogspot.com/2020/05/fixing-space-leaks-in-ghcide.html |
@cocreature the project already has a benchmark, comparing branches and running in ci, courtesy of @pepeiborra, so only regression tests would be needed to close this? |
@jneira yeah I think so. |
Detecting regressions in allocations would be sweet. Steps to do this:
|
1 is done, but 2 is still very much needed |
I supposethis still is not done |
done in #4203 |
It would be good to have some performance regression tests. We have a small wrapper around
lsp-tests
in DAML https://github.com/digital-asset/daml/blob/master/compiler/damlc/ide-debug-driver/README.md that makes it easy to script sessions which I’ve used successfully in the past to track down performance issues which might come in handy here.The text was updated successfully, but these errors were encountered: