Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prioritise completion suggestion of required fields #3758

Open
VeryMilkyJoe opened this issue Aug 16, 2023 · 0 comments
Open

Prioritise completion suggestion of required fields #3758

VeryMilkyJoe opened this issue Aug 16, 2023 · 0 comments
Labels
component: hls-cabal-plugin Issues related to the hls-cabal-plugin type: enhancement New feature or request

Comments

@VeryMilkyJoe
Copy link
Collaborator

Related to #3664.

When suggesting fields in the top level or in stanzas of a cabal file, it would be nice to prioritise suggestion of required fields over optional ones.
Additionally, it would be nice to label required fields as such using the details field of the CompletionItem.

  • In order to implement this, the data structure storing the keywords and their completers needs to be updated with some way of marking the required fields.
  • Then, the weightedConstantCompleter function can be used to prioritse the suggestion accordingly.
  • In order to add a label, the CompleterData probably needs to carry the information whether the suggested field is required.
@VeryMilkyJoe VeryMilkyJoe added type: enhancement New feature or request status: needs triage component: hls-cabal-plugin Issues related to the hls-cabal-plugin and removed status: needs triage labels Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: hls-cabal-plugin Issues related to the hls-cabal-plugin type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@VeryMilkyJoe