Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cabal Plugin Test Case is flaky #3333

Closed
fendor opened this issue Nov 13, 2022 · 2 comments
Closed

Cabal Plugin Test Case is flaky #3333

fendor opened this issue Nov 13, 2022 · 2 comments
Labels
component: hls-cabal-plugin Issues related to the hls-cabal-plugin type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@fendor
Copy link
Collaborator

fendor commented Nov 13, 2022

For certain GHC versions, the hls-cabal-plugin test-suite is flaky. This issue tracks a reminder that we should try to resolve it.

Testcase: "Diagnostics in .hs files from invalid .cabal file"
Run with TASTY_PATTERN="Diagnostics in .hs files from invalid" cabal test -w ghc-9.2.4 hls-cabal-plugin --test-show-details=direct to see the test failing (after removing the ignoreTestBecause line).

So far, we failed to figure out why the test-case is failing on some GHC versions occasionally. Here I try to document my debugging attempts, since we decided to merge the plugin with the flaky testcase disabled.

I am attaching here a failing and one succeeding test-run logs with -O1. Results look very different with -O0, but I think that's a general problem.

Succeeding test case with GHC 9.2.4
test.log

Failing test case with GHC 8.10.7
testfail.log

It is unfortunately even flaky, which GHC version fails to run the test.

My personal suspicion was that there is a bug in hls-graph, not re-running the rule although its dependencies have changed due to some race condition, but I was unable to make any progress on that suspicion.

Issue has been created in anticipation for the merge of #2940

@fendor fendor added type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. status: needs triage component: hls-cabal-plugin Issues related to the hls-cabal-plugin and removed status: needs triage labels Nov 13, 2022
@soulomoon
Copy link
Collaborator

Seems to be running fine now in 9.8.2, I suspect #4190 fix it. I'll try to send a PR to enable it to see if this would be working.

@fendor
Copy link
Collaborator Author

fendor commented May 28, 2024

Fixed by #4190

@fendor fendor closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: hls-cabal-plugin Issues related to the hls-cabal-plugin type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Development

No branches or pull requests

2 participants