Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sitemap logic needs to conform to specs. #592

Closed
chrissound opened this issue May 30, 2017 · 7 comments · Fixed by #1103
Closed

Sitemap logic needs to conform to specs. #592

chrissound opened this issue May 30, 2017 · 7 comments · Fixed by #1103

Comments

@chrissound
Copy link

chrissound commented May 30, 2017

2017-05-30-22 04 31

A quick google search for "haskell persistent insert" seems to return the docs for v0.3.1.3 (latest is v2.7).

I think if we set a higher priority for the latest version in the sitemap.xml - Google will pick this up and have the latest version higher up in the search results.

@hvr
Copy link
Member

hvr commented May 30, 2017

Here's what the sitemap says currently:

  <url>
    <loc>https://hackage.haskell.org/package/persistent/docs</loc>
    <lastmod>2017-04-17</lastmod>
    <changefreq>daily</changefreq>
    <priority>1.0</priority>
  </url>
  <url>
    <loc>https://hackage.haskell.org/package/persistent-0.3.1.3/docs</loc>
    <lastmod>2017-04-17</lastmod>
    <changefreq>monthly</changefreq>
    <priority>0.25</priority>
  </url>

So it does already use a higher priority for the unversioned URL which always points to the last version...

@chrissound
Copy link
Author

Hmm. The v2.7 entry is at a priority of 0.25 though.

(Please excuse the strange formatting).

><priority
>0.25</priority
></url
><url
><loc
>https://hackage.haskell.org/package/persistent-2.7.0/docs</loc

@hvr
Copy link
Member

hvr commented May 31, 2017

True, but if google already now doesn't appear to prefer persistent/docs over persistent-0.3.1.3/docs, why would it make a difference if the priority for persistent-2.7.0/docs would be inbetweeen? (I'm not saying we shouldn't try it, I'm just trying to understand why you think it would make a difference).

@chrissound
Copy link
Author

I'm honestly not too sure, I'm just taking a guess here.

@gbaz
Copy link
Contributor

gbaz commented Mar 19, 2018

I finally got us set up on the search management console and discovered that our sitemap is rejected by google :-/

"Your Sitemap contains too many URLs. Please create multiple Sitemaps with up to 50000 URLs each and submit all Sitemaps."

So we'll need to rethink some logic here.

@gbaz
Copy link
Contributor

gbaz commented Mar 20, 2018

actually its not rejected -- it just only accepts that first chunk of urls, which is the majority...

@gbaz
Copy link
Contributor

gbaz commented Mar 25, 2018

we can do multiple sitemaps as per: https://support.google.com/webmasters/answer/75712

Also sitemaps should have a link for every url, not just subdirectories.

@gbaz gbaz changed the title Sitemap should have lower priority for older package versions Sitemap logic needs to conform to specs. Mar 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants