Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow type in common stanzas or default to exitcode-stdio-1.0 #5531

Closed
daig opened this issue Aug 18, 2018 · 4 comments
Closed

Allow type in common stanzas or default to exitcode-stdio-1.0 #5531

daig opened this issue Aug 18, 2018 · 4 comments
Labels
Cabal: common stanza Concerning `common` stanzas in `.cabal` files

Comments

@daig
Copy link

daig commented Aug 18, 2018

Currently, cabal complains:

Unknown field: "type"
Test suite "my-test" is missing required field "type" ....

I don't see any reason that type should be excluded from common stantzas - does it make sense to add?

A minor annoyance, but in practice the boilerplate encourages monolithic test files

@hvr
Copy link
Member

hvr commented Aug 18, 2018

@daig there is a simple reason: common stanzas currently only allow fields which are applicable to all stanza kinds, iow, the common denominator; this was a deliberate design decision to simplify the semantics & implementation for the first iteration of common-stanzas.

See also #2832 for a discussion of how to model "typed common" stanzas which is what we'd need to address this.

@daig
Copy link
Author

daig commented Aug 18, 2018

Thanks, I had missed that discussion. It does make sense for a first iteration and I'm much glad to have existing common stanzas as an 80% solution. What is the best place to track discussion on the next iteration for common stanzas?

@hvr
Copy link
Member

hvr commented Aug 19, 2018

@daig keep watching this ticket and the original #2832; if any progress is made those tickets are very likely to get updated as well

@gbaz
Copy link
Collaborator

gbaz commented Sep 3, 2021

I think this is subsumed by #7459

@gbaz gbaz closed this as completed Sep 3, 2021
@andreasabel andreasabel added the Cabal: common stanza Concerning `common` stanzas in `.cabal` files label Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cabal: common stanza Concerning `common` stanzas in `.cabal` files
Projects
None yet
Development

No branches or pull requests

5 participants