Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cabal check should verify that the sdist, doesn't contain generated files #5128

Open
angerman opened this issue Feb 8, 2018 · 2 comments
Open

cabal check should verify that the sdist, doesn't contain generated files #5128

angerman opened this issue Feb 8, 2018 · 2 comments
Labels
cabal-install: cmd/check type: enhancement

Comments

@angerman
Copy link
Collaborator

angerman commented Feb 8, 2018 •
edited
Loading

With #4874 we start running configure in the build directory instead of the source directory. As such if the source directory contains files that are also generated by the configure script, this used to result in overridden files. Now we end up with two copies of the files. In the case of header files this can now results in compilation issues.

As such cabal check should verify that generated files do not end up in the source tarball.

See also haskell/network#307
@phadej
Copy link
Collaborator

phadej commented Feb 10, 2018

Is this something which can be solved by autogen-modules and #4943 and similar?

@ffaf1
Copy link
Collaborator

ffaf1 commented Feb 17, 2023

@angerman could you give us a commit where this happens, so I can see if it was fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cabal-install: cmd/check type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@angerman @23Skidoo @phadej @jneira @ffaf1